Skip to content

chore: map only used pihole API objects#60

Merged
DeepSpace2 merged 2 commits into
masterfrom
chore-lean-mapped-pihole-api-objects
Jul 7, 2026
Merged

chore: map only used pihole API objects#60
DeepSpace2 merged 2 commits into
masterfrom
chore-lean-mapped-pihole-api-objects

Conversation

@DeepSpace2

@DeepSpace2 DeepSpace2 commented Jul 7, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Refactor
    • Simplified internal DNS configuration handling to keep only host and CNAME record fields.
    • No user-facing behavior changes are expected from this update.

@coderabbitai

coderabbitai Bot commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@DeepSpace2, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 36 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d68a9f34-fedd-4106-8036-e943a5b9c1d9

📥 Commits

Reviewing files that changed from the base of the PR and between 5fc5b0e and bd65b14.

📒 Files selected for processing (1)
  • .pre-commit-config.yaml
📝 Walkthrough

Walkthrough

The configResponse.Config.DNS struct in pkg/clients/pihole/types.go was reduced to only two fields, Hosts and CnameRecords, removing numerous previously defined DNS configuration fields.

Changes

Pi-hole DNS Struct Reduction

Layer / File(s) Summary
Simplify Config.DNS type
pkg/clients/pihole/types.go		 Config.DNS struct is reduced to only Hosts ([]string) and CnameRecords ([]any), removing many previously declared DNS configuration fields.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the change to map only the Pihole API objects that are actually used.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@DeepSpace2 DeepSpace2 merged commit 3b35665 into master Jul 7, 2026
9 checks passed
@DeepSpace2 DeepSpace2 deleted the chore-lean-mapped-pihole-api-objects branch July 7, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@DeepSpace2